Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serving works with vanity URL knative.dev #1124

Merged
merged 6 commits into from
Jul 12, 2019
Merged

serving works with vanity URL knative.dev #1124

merged 6 commits into from
Jul 12, 2019

Conversation

chaodaiG
Copy link
Contributor

knative/serving is going to use vanity URL knative.dev as importing path, and this change is not planned to be backfilled into earlier release branches including 0.7. But presubmit and CI jobs are still needed for these old branches. So we will need to support 2 Prow jobs with same name but slightly different definition. For example:
For older branches:

branches:
    - "release-0.4"
    - "release-0.5"
    - "release-0.6"
    - "release-0.7"

For newer branches:

path_alias: knative.dev/serving
    skip_branches:
    - "release-0.4"
    - "release-0.5"
    - "release-0.6"
    - "release-0.7"

This PR provides a way of defining such a state, as well as applying this on serving repo.

/hold
Will need to coordinate with knative/serving#4521

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 10, 2019
@knative-prow-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2019
@chaodaiG
Copy link
Contributor Author

/uncc @dushyanthsc
/cc @mattmoor

@knative-prow-robot knative-prow-robot requested review from mattmoor and removed request for dushyanthsc July 10, 2019 21:14
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 10, 2019
adrcunha
adrcunha suggested changes Jul 10, 2019
View reviewed changes
ci/prow/make_config.go Outdated Show resolved Hide resolved
ci/prow/make_config.go Outdated Show resolved Hide resolved
ci/prow/make_config.go Outdated Show resolved Hide resolved
ci/prow/make_config.go Outdated Show resolved Hide resolved
ci/prow/make_config.go Outdated Show resolved Hide resolved
ci/prow/make_config.go Outdated Show resolved Hide resolved
ci/prow/make_config.go Outdated Show resolved Hide resolved
ci/prow/make_config.go Outdated Show resolved Hide resolved
adrcunha
adrcunha reviewed Jul 11, 2019
View reviewed changes
ci/prow/make_config.go Outdated Show resolved Hide resolved
ci/prow/make_config.go Outdated Show resolved Hide resolved
ci/prow/make_config.go Outdated Show resolved Hide resolved
ci/prow/make_config.go Outdated Show resolved Hide resolved
ci/prow/make_config.go Outdated Show resolved Hide resolved
ci/prow/make_config.go Outdated Show resolved Hide resolved
ci/prow/make_config.go Outdated Show resolved Hide resolved
adrcunha
adrcunha reviewed Jul 11, 2019
View reviewed changes
ci/prow/make_config.go Outdated Show resolved Hide resolved
@adrcunha
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2019
@chaodaiG
Copy link
Contributor Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2019
@chaodaiG
Copy link
Contributor Author

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2019
@chaodaiG
Copy link
Contributor Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2019
@knative-prow-robot knative-prow-robot merged commit bba720f into knative:master Jul 12, 2019
@chaodaiG chaodaiG mentioned this pull request Jul 13, 2019
Closed
@chaodaiG chaodaiG deleted the fork_presubmit_job branch July 29, 2019 20:35
chizhg pushed a commit to chizhg/test-infra that referenced this pull request Aug 8, 2019
@chaodaiG @chizhg
serving works with vanity URL knative.dev (knative#1124)
bd727b8 
* serving works with knative.dev

* Periodic jobs don't need this

* periodic jobs need path_alias too

* feedback updates

* resolve merge conflict

* feedback updates 2
Cynocracy pushed a commit to Cynocracy/test-infra that referenced this pull request Jun 13, 2020
@vagababov
Fix the nits leftover from knative#1118 review (knative#1124)
14a424a 
Fix the stuff that was not fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinivashegde86 srinivashegde86 srinivashegde86 left review comments

@adrcunha adrcunha adrcunha requested changes

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@adrcunha adrcunha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaodaiG @knative-prow-robot @adrcunha @srinivashegde86