Migrate serving to use the knative.dev/serving import path #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm I heartily endorse this PR. The overlapping of |
e17909e
to
c53304a
Compare
96baafb
to
c4eea68
Compare
c4eea68
to
34f3e2c
Compare
|
/hold cancel |
34f3e2c
to
f667360
Compare
``` sed -i '[email protected]/knative/[email protected]/serving@g' $(find -name '*.go' | xargs grep github.com/knative/serving | cut -d':' -f 1 | uniq) sed -i '[email protected]/knative/[email protected]/serving@g' $(find -name '*.yaml' | xargs grep github.com/knative/serving | cut -d':' -f 1 | uniq) ./hack/update-codegen.sh ```
f667360
to
0c94fbe
Compare
|
/retest |
|
/retest |
|
/test pull-knative-serving-go-coverage |
|
/test pull-knative-serving-integration-tests |
Merged
bbrowning
added a commit
to bbrowning/serving
that referenced
this pull request
Dec 14, 2019
In PR knative#4521 we accidentally replaced all https://github.com/knative/serving/... links in our Go source files with https://knative.dev/serving/... Those links should have been left as github.com. This fixes that. The commit is entirely scripted via: sed -i 's@https://knative.dev/serving@https://github.com/knative/serving@g' $(find -name '*.go' | xargs grep knative.dev/serving | cut -d':' -f 1 | uniq)
knative-prow-robot
pushed a commit
that referenced
this pull request
Dec 16, 2019
In PR #4521 we accidentally replaced all https://github.com/knative/serving/... links in our Go source files with https://knative.dev/serving/... Those links should have been left as github.com. This fixes that. The commit is entirely scripted via: sed -i 's@https://knative.dev/serving@https://github.com/knative/serving@g' $(find -name '*.go' | xargs grep knative.dev/serving | cut -d':' -f 1 | uniq)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have broken this into two commits:
This is a BREAKING change for all contributors
After this has merged, the following changes are needed:
knative/servingdirectory to${GOPATH}/src/knative.dev/servingIn order to merge this, we are going to have to effectively take a lock on Prow for a few hours because we will need to change the repository configuration and land this change (which also won't pass CI until that change is made).
Fixes: #971
/hold
Until after we cut 0.7, and land basically every change that's ready to go.