Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow job config generator supports generating multiple jobs with same name #1042

Closed
chaodaiG opened this issue Jun 25, 2019 · 5 comments
Closed
Assignees
Milestone

Comments

@chaodaiG
Copy link
Contributor

Currently Prow job config generator only supports generating one job for the same job name, which doesn't fit some of the upcoming jobs. For example, running perf test in different regions as #1041 , and vanity URL (knative.dev) migration need different jobs supporting old release branches.
It would be nice if prow job config generator can support generating multiple jobs with same name, ideally in a generic way.

@adrcunha
Copy link
Contributor

Looks like the generator needs to be rewritten. :)

@adrcunha adrcunha added this to the 2019Q3 milestone Jun 26, 2019
@adrcunha
Copy link
Contributor

/assign @chaodaiG

@chaodaiG
Copy link
Contributor Author

done via #1124

@chaodaiG
Copy link
Contributor Author

/close

@knative-prow-robot
Copy link
Collaborator

@chaodaiG: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Cynocracy pushed a commit to Cynocracy/test-infra that referenced this issue Jun 13, 2020
Produced via:
  `gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)`
  `goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party)`
/assign n3wscott
/cc n3wscott
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants