Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pkg to use the knative.dev/pkg import path #489

Merged
merged 2 commits into from
Jun 26, 2019

Conversation

mattmoor
Copy link
Member

I have broken this into two commits:

  1. The manual changes I made.
  2. The scripted changes I made.

This is a BREAKING change for all contributors

After this has merged, the following changes are needed:

  1. Move or recreate your knative/serving directory to ${GOPATH}/src/knative.dev/pkg
  2. Run the following sed command pkg any outstanding changes:
sed -i '[email protected]/knative/[email protected]/pkg@g' $(find -name '*.go' | xargs grep github.com/knative/pkg | cut -d':' -f 1 | uniq)

In order to merge this, we are going to have to effectively take a lock on Prow for a few hours because we will need to change the repository configuration and land this change (which also won't pass CI until that change is made).

Related to: knative/serving#971

/hold

Until after we cut 0.7 (even though this is cut for pkg, I don't want to risk the other cuts).

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 25, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 25, 2019
@chaodaiG
Copy link
Contributor

/retest

@chaodaiG
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2019
@chaodaiG
Copy link
Contributor

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2019
@Harwayne
Copy link
Contributor

  1. Move or recreate your knative/serving directory to ${GOPATH}/src/knative.dev/pkg

This should be knative/pkg, right?

@knative-prow-robot knative-prow-robot merged commit 222dd25 into knative:master Jun 26, 2019
@mattmoor mattmoor deleted the knative-pkg branch June 26, 2019 20:04
@jchesterpivotal
Copy link
Contributor

/lgtm

for same reasons as given in knative/serving#4521.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants