fix(cypress): address cypress skipping tests

[pixincreate]

Type of Change

• Bugfix
• New feature
• Enhancement
• Refactoring
• Dependency updates
• Documentation
• CI/CD

Description

This PR fixes error introduced in commit 24217d1 (#4904) of PR #4904 which led to tests getting skipped on single test failure which went unnoticed (After this change, when I ran the tests, things were working fine, not sure what went down the line). But that commit seems to fix it.

Additional Changes

• This PR modifies the API contract
• This PR modifies the database schema
• This PR modifies application configuration/environment variables

Motivation and Context

Closes #5047

How did you test it?

Wrote below script to run tests in parallel (parallel tests require a lot of resource, else, tests become flaky):

#! /bin/bash

# DECLARATIONS
export DEBUG=cypress:cli

# Set the environment variables for the tests before running them
export CYPRESS_BASEURL="http:https://localhost:8080"
export CYPRESS_ADMINAPIKEY='test_admin'
export CYPRESS_CONNECTOR_AUTH_FILE_PATH='${HOME}/creds.json'
CONNECTORS=("adyen" "bankofamerica" "bluesnap" "cybersource" "nmi" "paypal" "stripe" "trustpay")
export CYPRESS_HS_EMAIL='[email protected]'
export CYPRESS_HS_PASSWORD='secret_password'

mkdir -p results

for connector in "${CONNECTORS[@]}"; do
  CYPRESS_CONNECTOR="${connector}" npm run cypress:ci > results/${connector}.txt 2>&1 &
done

wait

ETA:

Parallel Tests

(Ran it after PC cooled down and had available resources)

Adyen	Bank of America	Bluesnap	Cybersource
NMI	PayPal	Stripe	Trustpay

Important

When running in parallel, Bluesnap and NMI have higher failure rates compared to other connectors. RCA has to be done. It is not a priority as of now.

One test at a time

Adyen	Bank of America	Bluesnap	Cybersource
NMI	PayPal	Stripe	Trustpay

Important

Trustpay failing is server side issue.

Checklist

• I formatted the code cargo +nightly fmt --all
• I addressed lints thrown by cargo clippy
• I reviewed the submitted code
• I added unit tests for my changes where possible

The base branch was changed.