Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker-compose): pass correct configuration values for running SDK demo app #5012

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

SanchithHegde
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR includes the following changes to the Docker Compose setup:

  • Adds health checks for PostgreSQL and Redis containers.
  • Specifies the dependencies among services.
  • Specifies the correct environment variables for the hyperswitch-web service so that the SDK demo app works correctly.

Motivation and Context

More robust Docker Compose setup, and enabling the SDK demo app.

How did you test it?

Locally, with the Docker Compose setup:

Screenshot of locally running demo app

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@SanchithHegde SanchithHegde added A-infra Area: Infrastructure C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 14, 2024
@SanchithHegde SanchithHegde added this to the June 2024 Release milestone Jun 14, 2024
@SanchithHegde SanchithHegde self-assigned this Jun 14, 2024
@SanchithHegde SanchithHegde requested review from a team as code owners June 14, 2024 11:08
docker-compose-development.yml Show resolved Hide resolved
@@ -158,7 +179,10 @@ services:
volumes:
- ./config/dashboard.toml:/tmp/dashboard-config.toml
depends_on:
- hyperswitch-web
hyperswitch-server:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had left out hyperswitch-server as a dependency so people can run the control center with their local cargo run

docker-compose.yml Show resolved Hide resolved
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 91c8af6 Jun 18, 2024
15 checks passed
@Gnanasundari24 Gnanasundari24 deleted the docker-compose-sdk-demo-app branch June 18, 2024 09:31
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jun 18, 2024
pixincreate added a commit that referenced this pull request Jun 20, 2024
…ress-skip

* 'main' of github.com:juspay/hyperswitch: (27 commits)
  feat(cypress): add 2 more payout connectors and bank transfer support for payout (#4993)
  chore(version): 2024.06.20.0
  Refactor(core): reverts the payment method list filtering using constraint graph (#5044)
  feat(router): add payment method type duplication check for `google_pay` (#5023)
  refactor(storage): remove `id` from payment intent, attempt and remove datamodel ext from payment intent (#4923)
  fix(events): Correct parsing of API events with user event_type for Clickhouse (#5022)
  fix(connector):  add local bank redirect type in compatibility layer, default the country to AT for Local Bank Redirect and add creds_identifier in access token  (#5038)
  refactor(connector): add amount conversion framework for noon (#4843)
  fix(logging): fix stack overflow on recording restricted keys (#4423)
  feat(core): Add logger for sessions call failure (#5036)
  chore(version): 2024.06.19.0
  fix(opensearch): handle index not present errors in search api (#4965)
  feat(multitenancy): add tenant_id as a field for data pipeline and support individual database for clickhouse  (#4867)
  refactor: add basic counter metrics for IMC (#5006)
  fix(payment_methods): populate card fields while saving card again during metadata change condition (#5019)
  feat(router): Override the `setup_future_usage` to `on_session` based on the merchant config (#5016)
  chore(docker-compose): pass correct configuration values for running SDK demo app  (#5012)
  refactor: Move trait ConnectorIntegration to crate hyperswitch_interfaces (#4946)
  chore(version): 2024.06.17.0
  chore(process_tracker): use `const` instead of `String` for `business_status` (#4849)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infra Area: Infrastructure C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants