Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply Polars SQL count(*) group by fix #1837

Merged
merged 5 commits into from
May 24, 2024
Merged

apply Polars SQL count(*) group by fix #1837

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2bd346c
`deps`: use patched polars 0.40.0
jqnatividad May 24, 2024
7c93cc6
`sqlp`: add polars cwc optstate
jqnatividad May 24, 2024
c8041e1
`count`: add polars cwc optstate
jqnatividad May 24, 2024
f8aa66f
`joinp`: `JoinType::Outer` is now `JoinType::Full`; add polars cwc o…
jqnatividad May 24, 2024
66c51a6
`tests`: reenable `sqlp` tests we disabled
jqnatividad May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
count: add polars cwc optstate
  • Loading branch information
@jqnatividad
jqnatividad committed May 24, 2024
commit c8041e1634019c4a89890d4055cc12f5d9bb9af7
25 changes: 13 additions & 12 deletions src/cmd/count.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,18 +237,19 @@ pub fn polars_count_input(
},
};
let optimization_state = polars::lazy::frame::OptState {
projection_pushdown: true,
predicate_pushdown: true,
type_coercion: true,
simplify_expr: true,
file_caching: true,
slice_pushdown: true,
comm_subplan_elim: false,
comm_subexpr_elim: true,
streaming: true,
fast_projection: true,
eager: false,
row_estimate: true,
projection_pushdown: true,
predicate_pushdown: true,
cluster_with_columns: true,
type_coercion: true,
simplify_expr: true,
file_caching: true,
slice_pushdown: true,
comm_subplan_elim: false,
comm_subexpr_elim: true,
streaming: true,
fast_projection: true,
eager: false,
row_estimate: true,
};
ctx.register("sql_lf", lazy_df.with_optimizations(optimization_state));
"SELECT COUNT(*) FROM sql_lf".to_string()
Expand Down