Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply Polars SQL count(*) group by fix #1837

Merged
merged 5 commits into from
May 24, 2024

Conversation

jqnatividad
Copy link
Owner

@jqnatividad jqnatividad merged commit d427014 into master May 24, 2024
14 checks passed
@jqnatividad jqnatividad deleted the polars-countstar-groupby-fix branch May 26, 2024 13:06
@alexander-beedie
Copy link

FYI: new release 0.20.30 contains the fix ✌️

@jqnatividad
Copy link
Owner Author

Thanks @alexander-beedie !

I ended up using patch.crates.io to get the fix...

qsv/Cargo.toml

Lines 244 to 254 in ec5f653

[patch.crates-io]
# needed as dynfmt doesn't work in release mode without this
dynfmt = { git = "https://github.com/jqnatividad/dynfmt", branch = "2021-clippy_ptr_as_ptr-bumpdeps" }
# needed to get latest dependencies and unreleased fixes
grex = { git = "https://github.com/pemistahl/grex", rev = "0c8ab87" }
# use our fork of calamine to use latest zip 2.1 crate
# which has better performance and several bug fixes
calamine = { git = "https://github.com/jqnatividad/calamine", branch = "bump_zip_from_1_to_2" }
# polars 0.40.0 with unreleased fixes
polars = { git = "https://github.com/pola-rs/polars", rev = "d68d499" }
polars-ops = { git = "https://github.com/pola-rs/polars", rev = "d68d499" }

Will be sure to spread the Polars' love at csvconf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants