Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply Polars SQL count(*) group by fix #1837

Merged
merged 5 commits into from
May 24, 2024
Merged

apply Polars SQL count(*) group by fix #1837

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2bd346c
`deps`: use patched polars 0.40.0
jqnatividad May 24, 2024
7c93cc6
`sqlp`: add polars cwc optstate
jqnatividad May 24, 2024
c8041e1
`count`: add polars cwc optstate
jqnatividad May 24, 2024
f8aa66f
`joinp`: `JoinType::Outer` is now `JoinType::Full`; add polars cwc o…
jqnatividad May 24, 2024
66c51a6
`tests`: reenable `sqlp` tests we disabled
jqnatividad May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tests: reenable sqlp tests we disabled 
because of polars count(*) group by bug
  • Loading branch information
@jqnatividad
jqnatividad committed May 24, 2024
commit 66c51a60fe32cc010f25494c2c39b29f15805697
14 changes: 7 additions & 7 deletions tests/test_sqlp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ fn sqlp_join_cross() {
}

#[test]
#[ignore = "temporarily disable due to a bug in polars aliasing"]
// #[ignore = "temporarily disable due to a bug in polars aliasing"]
fn sqlp_boston311_groupby_orderby() {
let wrk = Workdir::new("sqlp_boston311_groupby_orderby");
let test_file = wrk.load_test_file("boston311-100.csv");
Expand Down Expand Up @@ -206,7 +206,7 @@ fn sqlp_boston311_groupby_orderby() {
}

#[test]
#[ignore = "temporarily disable due to a bug in polars aliasing"]
// #[ignore = "temporarily disable due to a bug in polars aliasing"]
fn sqlp_boston311_groupby_orderby_with_table_alias() {
let wrk = Workdir::new("sqlp_boston311_groupby_orderby");
let test_file = wrk.load_test_file("boston311-100.csv");
Expand Down Expand Up @@ -852,7 +852,7 @@ fn sqlp_boston311_explain() {
}

#[test]
#[ignore = "temporarily disable due to a bug in polars aliasing"]
// #[ignore = "temporarily disable due to a bug in polars aliasing"]
fn sqlp_boston311_sql_script() {
let wrk = Workdir::new("sqlp_boston311_sql_script");
let test_file = wrk.load_test_file("boston311-100.csv");
Expand Down Expand Up @@ -889,7 +889,7 @@ select ward,count(*) as cnt from temp_table2 group by ward order by cnt desc, wa
}

#[test]
#[ignore = "temporarily disable due to a bug in polars aliasing"]
// #[ignore = "temporarily disable due to a bug in polars aliasing"]
fn sqlp_boston311_sql_script_json() {
let wrk = Workdir::new("sqlp_boston311_sql_script_json");
let test_file = wrk.load_test_file("boston311-100.csv");
Expand All @@ -913,7 +913,7 @@ select ward,count(*) as cnt from temp_table2 group by ward order by cnt desc, wa
}

#[test]
#[ignore = "temporarily disable due to a bug in polars aliasing"]
// #[ignore = "temporarily disable due to a bug in polars aliasing"]
fn sqlp_boston311_sql_script_jsonl() {
let wrk = Workdir::new("sqlp_boston311_sql_script_jsonl");
let test_file = wrk.load_test_file("boston311-100.csv");
Expand Down Expand Up @@ -945,7 +945,7 @@ select ward,count(*) as cnt from temp_table2 group by ward order by cnt desc, wa
}

#[test]
#[ignore = "temporarily disable due to a bug in polars aliasing"]
// #[ignore = "temporarily disable due to a bug in polars aliasing"]
fn sqlp_boston311_cte_script() {
let wrk = Workdir::new("sqlp_boston311_cte");
let test_file = wrk.load_test_file("boston311-100.csv");
Expand Down Expand Up @@ -973,7 +973,7 @@ select ward,count(*) as cnt from boston311_roxbury group by ward order by cnt de
}

#[test]
#[ignore = "temporarily disable due to a bug in polars aliasing"]
// #[ignore = "temporarily disable due to a bug in polars aliasing"]
fn sqlp_boston311_cte() {
let wrk = Workdir::new("sqlp_boston311_cte");
let test_file = wrk.load_test_file("boston311-100.csv");
Expand Down
Loading