Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Add tests for formatRelativeDate #1765

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

Lauquik
Copy link
Contributor

@Lauquik Lauquik commented Sep 6, 2023

Which problem is this PR solving?

Description of the changes

  • added test coverage for formatRelativeDate in /src/utils/date.test.js

How was this change tested?

  • manually on my local envrionment

Checklist

Signed-off-by: Lauquik <[email protected]>

added test for formatRelativeDate in /packages/src/utils/date.test.js
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yurishkuro yurishkuro changed the title added test for formatRelativeDate [tests] Add tests for formatRelativeDate Sep 6, 2023
@yurishkuro yurishkuro enabled auto-merge (squash) September 6, 2023 14:02
@yurishkuro
Copy link
Member

CI failed, not sure if it's related to this change:

FAIL  src/components/TracePage/TraceTimelineViewer/VirtualizedTraceView.test.js
  ● Test suite failed to run

    RangeError: Error while computing Critical Path Algorithm.

      85 |             // Never reaches to default
      86 |             // Something unexpected happened
    > 87 |             throw RangeError(`Error while computing Critical Path Algorithm.`);
         |                   ^
      88 |         }
      89 |       } else {
      90 |         // Drop the child spans of dropped parent span

      at RangeError (src/components/TracePage/CriticalPath/utils/sanitizeOverFlowingChildren.tsx:87:19)
          at Array.forEach (<anonymous>)
      at forEach (src/components/TracePage/CriticalPath/utils/sanitizeOverFlowingChildren.tsx:28:11)
      at TraceCriticalPath (src/components/TracePage/CriticalPath/index.tsx:97:57)
      at apply (../../node_modules/memoize-one/dist/memoize-one.cjs.js:39:[35](https://github.com/jaegertracing/jaeger-ui/actions/runs/6097877025/job/16547274543?pr=1765#step:5:36))
      at src/components/TracePage/TraceTimelineViewer/VirtualizedTraceView.test.js:[37](https://github.com/jaegertracing/jaeger-ui/actions/runs/6097877025/job/16547274543?pr=1765#step:5:38):49
      at Object.describe (src/components/TracePage/TraceTimelineViewer/VirtualizedTraceView.test.js:31:1)

cc @GLVSKiriti

@yurishkuro
Copy link
Member

restarted CI, in case it was a spurious error

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@yurishkuro
Copy link
Member

CI succeeded, must have been spurious error - tracked in #1766

@yurishkuro yurishkuro merged commit addbe55 into jaegertracing:main Sep 6, 2023
9 checks passed
@Lauquik
Copy link
Contributor Author

Lauquik commented Sep 6, 2023

thanks @yurishkuro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tests] Another flaky test seems to be introduced
2 participants