Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Unexpected error in Critical Path computation #1766

Closed
yurishkuro opened this issue Sep 6, 2023 · 4 comments
Closed

[bug] Unexpected error in Critical Path computation #1766

yurishkuro opened this issue Sep 6, 2023 · 4 comments

Comments

@yurishkuro
Copy link
Member

See #1765 (comment)

cc @GLVSKiriti
@yurishkuro yurishkuro mentioned this issue Sep 6, 2023
Merged
4 tasks
@joe-elliott
Copy link
Member

Just saw this issue while cutting v1.33.0.

@yurishkuro
Copy link
Member Author

yeah, I think we need a try/catch around CP function invocation so that if it bombs we just don't display CP but the UI still works. I should be able to patch it tonight.

@yurishkuro yurishkuro mentioned this issue Sep 6, 2023
Merged
yurishkuro added a commit that referenced this issue Sep 6, 2023
@yurishkuro
Catch exception from Critical Path code to protect the rest of the UI (…
f0dff93 
…#1768)

Related to #1766

Signed-off-by: Yuri Shkuro <[email protected]>
@GLVSKiriti
Copy link
Contributor

GLVSKiriti commented Sep 14, 2023 •
edited
Loading

@yurishkuro can't we also close this issue through PR's #1780 and #1785

Or anything more left here to do?

@yurishkuro
Copy link
Member Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joe-elliott @yurishkuro @GLVSKiriti