Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Another flaky test seems to be introduced #1747

Closed
yurishkuro opened this issue Sep 1, 2023 · 2 comments · Fixed by #1765
Closed

[tests] Another flaky test seems to be introduced #1747

yurishkuro opened this issue Sep 1, 2023 · 2 comments · Fixed by #1765
Labels
good first issue help wanted

Comments

@yurishkuro
Copy link
Member

A couple PRs failed with a drop of code coverage, even though they did not change the code in question (e.g. one was dependencies upgrade). Codecov shows the issue in the date.tsx util file

image

It is possible that the function being tested executes different code paths depending on time of day or some other variable, which should really be controlled better from within the test.
@suhail34
Copy link
Contributor

suhail34 commented Sep 1, 2023

I would like to take this one up to work

@dhiraj0911
Copy link

I would like to work on this issue

@Lauquik Lauquik mentioned this issue Sep 6, 2023
Merged
4 tasks
yurishkuro pushed a commit that referenced this issue Sep 6, 2023
@Lauquik
[tests] Add tests for formatRelativeDate (#1765)
addbe55 
## Which problem is this PR solving?
- Resolves #1747

## Description of the changes
- added test coverage for formatRelativeDate in /src/utils/date.test.js

## How was this change tested?
-  manually on my local envrionment

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tests] Add tests for formatRelativeDate Lauquik/jaeger-ui
3 participants
@yurishkuro @suhail34 @dhiraj0911