-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganizes the structure to drop omni.isaac
and directly use isaaclab
as extension name
#590
base: main
Are you sure you want to change the base?
Conversation
Does this also work with Isaac Sim 2023.1.1? Just wondering if Kit 105.1 already supported a single extension name. Otherwise, this change also means a drop in support for 2023.1.1. |
@Mayankm96 I can test it but are we backward compatible in general so far with the code changes? |
@pascal-roth We discussed this internally, and Isaac Sim will change its extension naming following a style similar to the above in November. We have received push-back to do this change as it will break the user's experience twice (once now and again in November when Isaac Sim breaks the APIs). Hence, we have also decided to do this in November with Isaac Sim. |
There is no need for a review now; will be addressed in November when IsaacSim will also be renamed. Keep the PR open as information. |
Description
Reorganize the extensions to achieve a simpler and easier-to-understand structure. We make use of Kit 106, which drops the requirement to have the extension name as a composition of at least two elements separated by a dot and instead allows for a single word as name. Consequently, the extensions are renamed as follows:
omni.isaac.lab
-->isaaclab
omni.isaac.lab_tasks
-->isaaclab_tasks
omni.isaac.lab_assets
-->isaaclab_assets
This reduces the structure from
omni.isaac.lab/omni/isaac/lab
toisaaclab/isaaclab
.Type of change
Screenshots
While extensions can still be found as expected
Checklist
pre-commit
checks with./isaaclab.sh --format
./isaaclab.sh --test
and they passconfig/extension.toml
fileCONTRIBUTORS.md
or my name already exists there