feat: Improve version constraining #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using 'version-constraint key' instead of 'queue-id' to be more descriptive. Celery terminology is already opaque to end users, i.e. 'routing-key' vs 'queue'. Queue is both a noun and a verb, and refers to both Celery's queue name that receives queued tasks as well as the act of queuing them.
File was being written with "" as key, since variable reference was wrong.
…/github.com/in03/resolve-proxy-encoder into feat/issue-151/improve-version-constraining
…/github.com/in03/resolve-proxy-encoder into feat/issue-151/improve-version-constraining
- moved hefty imports to CLI sub-commands for faster loading time and quicker UI responsiveness - queuer checks other workers compatibility against its own `version_constraint_key` file TODO: - get worker queue name from `version_constraint_key` file, otherwise all locally workers will still be using git-sha mechanism, including self. - implement `--hide_banner` option globally with Typer - implement `RPROX_HIDE_BANNER` environment variable - further test version collision probability
…/github.com/in03/resolve-proxy-encoder into feat/issue-151/improve-version-constraining
Still in a bit of a weird place with terminology here. We have `queue`, `version constraint key` and `routing key`. The choice to refer to the name of the queue as `version constraint key` better reflects application usage and user expectations. "Queue" on its own is both a noun and a verb and we already use the term to describe a module and the process of "queuing" proxies. Some additional terminology changes in code may be necessary at a later date.
github-actions
bot
force-pushed
the
feat/issue-151/improve-version-constraining
branch
from
8852a87
to
924672f
Compare
This was referenced Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new version-constraint system independent of actual application versioning. This side-steps the need for complicated logic to support local git builds, direct URL git builds and PyPi release builds. It also means we can support compatibility between those multiple builds' versioning systems if the codebase is exactly the same.
Changes
.gitignoredeletion (fixed) :rolleyes:Further considerations:
This repo, 'python-petname' might be a better option for generating names. It has a longer word list, including adverbs and adjectives; handles alliteration automatically and allows for a custom word-chain length. It doesn't exist as a GitHub action though and uses an Apache license. Might be an opportunity for inspiration.
It would be good to give the whole repo a license check actually! MIT is quite permissive and might not be accommodating some used libraries.
We also need to test PyPi release support. When does Poetry build and upload to PyPi? We need to build releases and upload AFTER the VC key action. Maybe we can use an additional GitHub action to build releases for us.
Addresses discussion in #151
pre-commit.ci autofix