Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve version constraining #165

Merged
merged 21 commits into from
Jun 10, 2022

Commits on Jun 7, 2022

  1. Configuration menu
    Copy the full SHA
    6849e51 View commit details
    Browse the repository at this point in the history
  2. ci: test queue-id action

    in03 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    a3c639e View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. ci: fix broken git push ref

    in03 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    bc92cfe View commit details
    Browse the repository at this point in the history
  2. ci: Update Queue-ID file

    Update-Queue-ID committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    b8de76f View commit details
    Browse the repository at this point in the history
  3. ci: terminology change - 'version-constraint key'

    Using 'version-constraint key' instead of 'queue-id' to be more descriptive.
    Celery terminology is already opaque to end users, i.e. 'routing-key'
    vs 'queue'. Queue is both a noun and a verb, and refers to both Celery's
    queue name that receives queued tasks as well as the act of queuing them.
    in03 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    c503e40 View commit details
    Browse the repository at this point in the history
  4. ci: Fix incorrect variable name

    File was being written with "" as key, since variable reference was wrong.
    in03 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    ac37acf View commit details
    Browse the repository at this point in the history
  5. Merge branch 'feat/issue-151/improve-version-constraining' of https:/…

    …/github.com/in03/resolve-proxy-encoder into feat/issue-151/improve-version-constraining
    in03 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    1f8c885 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    57480ce View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    277ba2b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4101b13 View commit details
    Browse the repository at this point in the history
  9. Merge branch 'feat/issue-151/improve-version-constraining' of https:/…

    …/github.com/in03/resolve-proxy-encoder into feat/issue-151/improve-version-constraining
    in03 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    f75fb69 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    fad3134 View commit details
    Browse the repository at this point in the history
  11. feat: implement mnemonic version constrain key

    - moved hefty imports to CLI sub-commands for faster loading time and
    quicker UI responsiveness
    
    - queuer checks other workers compatibility against its own
    `version_constraint_key` file
    
    TODO:
    
    - get worker queue name from `version_constraint_key` file, otherwise
    all locally workers will still be using git-sha mechanism, including self.
    
    - implement `--hide_banner` option globally with Typer
    
    - implement `RPROX_HIDE_BANNER` environment variable
    
    - further test version collision probability
    in03 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    9530708 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    df29b23 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Configuration menu
    Copy the full SHA
    3906495 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e3db053 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'feat/issue-151/improve-version-constraining' of https:/…

    …/github.com/in03/resolve-proxy-encoder into feat/issue-151/improve-version-constraining
    in03 committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    a2ec506 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. refactor(launch_workers.py): logging queue-name reflect term change

    Still in a bit of a weird place with terminology here. We have `queue`, `version constraint key` and `routing key`. The choice to refer to the name of the queue as `version constraint key` better reflects application usage and user expectations. "Queue" on its own is both a noun and a verb and we already use the term to describe a module and the process of "queuing" proxies. Some additional terminology changes in code may be necessary at a later date.
    in03 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    9c6aeac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9f70016 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    12b0afb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    924672f View commit details
    Browse the repository at this point in the history