Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git short sha used for queue slices from end instead of beginning #155

Closed
in03 opened this issue Jun 3, 2022 · 1 comment
Closed

Git short sha used for queue slices from end instead of beginning #155

in03 opened this issue Jun 3, 2022 · 1 comment
Assignees

Comments

@in03
Copy link
Owner

in03 commented Jun 3, 2022

Git short shas are the first several digits, not the last.
Not essential, just good to keep consistent with the standard.

@in03
Copy link
Owner Author

in03 commented Jun 14, 2022

Implemented in #165

Changed the slicing in all places where git SHAs are printed, e.g. for the new CLI banner build print. Now using a custom key for version constraint (queues, routing keys, etc), so this change has no implications on version constraining.

@in03 in03 closed this as completed Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant