Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #212

Merged
merged 116 commits into from
Jul 17, 2019
Merged

Release #212

merged 116 commits into from
Jul 17, 2019

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented Jul 1, 2019

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)
  • Code coverage improves or is at 100% (remove this if not merging to master)

Description

Version release. Includes the following PRs:

landonreed and others added 30 commits June 8, 2017 17:10
Conflicts:
	src/main/java/com/conveyal/datatools/manager/controllers/api/FeedVersionController.java
	src/main/java/com/conveyal/datatools/manager/jobs/MergeProjectFeedsJob.java
semantic-release v16 is going to have a breaking change that will make maven-semantic-release not work properly.
Cache yarn stuff and preemptively fix semantic-release to v15
Add item about referencing PRs in PRs to master
Log response body when an error from auth0 is received
Also, improve error handling of Auth0Users.java
Tweaks for Auth0 error improvements
@codecov-io
Copy link

Codecov Report

Merging #212 into master will increase coverage by 1.43%.
The diff coverage is 56.93%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #212      +/-   ##
============================================
+ Coverage     16.84%   18.27%   +1.43%     
- Complexity      325      328       +3     
============================================
  Files           151      148       -3     
  Lines          8794     7364    -1430     
  Branches       1288      980     -308     
============================================
- Hits           1481     1346     -135     
+ Misses         7181     5896    -1285     
+ Partials        132      122      -10
Impacted Files Coverage Δ Complexity Δ
...s/editor/controllers/api/EditorControllerImpl.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...l/datatools/manager/jobs/ProcessSingleFeedJob.java 68.42% <ø> (ø) 4 <0> (ø) ⬇️
...datatools/editor/jobs/ConvertEditorMapDBToSQL.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...com/conveyal/datatools/manager/models/Project.java 23.07% <ø> (-3.76%) 2 <0> (-1)
...al/datatools/manager/models/FeedDownloadToken.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...tatools/manager/gtfsplus/tables/RealtimeRoute.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...tools/editor/controllers/api/EditorController.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...atatools/manager/gtfsplus/tables/RealtimeStop.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ols/editor/controllers/api/SnapshotController.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/com/conveyal/datatools/manager/auth/Actions.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6ad83...a68aa5f. Read the comment docs.

Copy link
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but the next release must include #167 once that is updated to work w/ MS Teams.

@evansiroky evansiroky assigned landonreed and unassigned evansiroky Jul 1, 2019
@landonreed
Copy link
Contributor Author

@evansiroky, are you OK with us just creating a release without the end to end testing for now?

@landonreed landonreed assigned evansiroky and unassigned landonreed Jul 17, 2019
@evansiroky
Copy link
Contributor

Yeah, I'm fine without the e2e tests working for this release.

@evansiroky evansiroky assigned landonreed and unassigned evansiroky Jul 17, 2019
@landonreed landonreed merged commit bcfc11a into master Jul 17, 2019
@landonreed
Copy link
Contributor Author

🎉 This PR is included in version 3.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants