Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log response body when an error from auth0 is received #184

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

evansiroky
Copy link
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

While investigating an issue of a failing Auth0 operation, I needed to view the response body from Auth0 to discover what the error message was. This PR seeks to add logging of the response body when a failed Auth0 API call occurs.

@codecov-io
Copy link

Codecov Report

Merging #184 into dev will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##               dev    #184      +/-   ##
==========================================
- Coverage     5.16%   5.16%   -0.01%     
  Complexity      94      94              
==========================================
  Files          133     133              
  Lines         6934    6935       +1     
  Branches       908     909       +1     
==========================================
  Hits           358     358              
- Misses        6548    6549       +1     
  Partials        28      28
Impacted Files Coverage Δ Complexity Δ
...atools/manager/controllers/api/UserController.java 8.12% <0%> (-0.05%) 2 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6ad83...88a57cd. Read the comment docs.

@landonreed landonreed assigned evansiroky and unassigned landonreed Feb 15, 2019
@landonreed landonreed merged commit 065c1ec into dev Feb 15, 2019
@landonreed landonreed deleted the auth0-error-response-logging branch February 15, 2019 21:32
@landonreed landonreed mentioned this pull request Jul 1, 2019
8 tasks
@landonreed
Copy link
Contributor

🎉 This PR is included in version 3.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants