Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add item about referencing PRs in PRs to master #175

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

evansiroky
Copy link
Contributor

@evansiroky evansiroky commented Feb 12, 2019

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented

N/A - just changes the PR template

  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings

N/A

  • All tests and CI builds passing

Description

This PR seeks to improve the PR template by asking for relevant PRs to be included in descriptions when merging to master.

@codecov-io
Copy link

Codecov Report

Merging #175 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               dev    #175   +/-   ##
=======================================
  Coverage     5.14%   5.14%           
  Complexity      94      94           
=======================================
  Files          133     133           
  Lines         6926    6926           
  Branches       908     908           
=======================================
  Hits           356     356           
  Misses        6542    6542           
  Partials        28      28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80ebd88...17f651e. Read the comment docs.

@landonreed landonreed merged commit 4c93b80 into dev Feb 15, 2019
@landonreed landonreed deleted the pr-template-addition branch February 15, 2019 21:28
@landonreed landonreed mentioned this pull request Jul 1, 2019
8 tasks
@landonreed
Copy link
Contributor

🎉 This PR is included in version 3.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants