docs(secrets-engines): Add database secrets engine docs

[amiewei]

Add docs for the database secrets engine - #453

I've added docs/code examples for the majority of methods but missing the static role related methods. I plan on adding them at a later time once I test them.

[codecov]

Codecov Report

Merging #1036 (ff084f3) into main (9172473) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1036   +/-   ##
=======================================
  Coverage   84.99%   85.00%           
=======================================
  Files          65       65           
  Lines        3133     3135    +2     
=======================================
+ Hits         2663     2665    +2     
  Misses        470      470           

see 1 file with indirect coverage changes

[briantist]

Hi @amiewei , welcome! Thank you for putting up this much-needed documentation for the database secrets engine. I'll take a closer look at the content itself as soon as I can.

In the meantime, it seems there are a lot of changes to the poetry configuration in here that we're not quite ready to make yet. Would you be able to revert the changes to poetry.lock and pyproject.toml? If there's something about those changes that are required for the documentation updates, please let me know.

Thanks!

[amiewei]

heyhey, thanks for looking at this quickly :)

I tried reverting the poetry.lock and pyproject.toml files by essentially deleting those two files locally, then copying the poetry.lock from upstream and reinstalling the packages to auto-regenerate the pyproject.toml. Looking at the diff, I think there are still some differences comparing the auto-generated toml file from the original one.

im not well versed in poetry - pun intended, so let me know if this is ok or if there's a better way to revert it 😅. Regardless, i updated the commit based on the above

[briantist]

im not well versed in poetry - pun intended

😆 neither am I, either kind

the auto-generated toml file from the original one

Do you know why the file is being auto-generated at all for this change? Are there some commands you're running locally?

I figured if you did git checkout main -- poetry.lock pyproject.toml that should restore the files from main, and then if you commit those and push, it should result in no changes to them in this PR, but I'm still wondering how they got changed in the first place.

[amiewei]

alright i used your command thank you and updated the commit.. 3rd time is the charm? 😅

[briantist]

ok, finally had a chance to look at this more closely. It's really great! All my suggested changes are really minor.

For sentence-ending punctuations on descriptions, I used colon : because one of yours had it already, but I'd also be fine with making them all period/full-stop . instead.

If you like the suggestions as-is and want to commit from the GitHub UI, use the Files tab in the PR to look at them, that way you can click "Add suggestion to batch" and then commit all the ones you want at once.

Also fine to make changes locally and push them up.

[briantist]

Also if you're ok me pushing these changes, I can take care of that for you and get this merged in.

[amiewei]

looks good! thanks for going through it :)

[briantist]

Looks great! Thanks so much for improving the documentation. I think you've seen this already but we're looking for help in the project and these improvements are a huge help, hope to see you around with more changes!