Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database secrets engine needs documentation & design alignment #453

Closed
drewmullen opened this issue May 28, 2019 · 9 comments
Closed

database secrets engine needs documentation & design alignment #453

drewmullen opened this issue May 28, 2019 · 9 comments
Labels
database database secrets engine documentation documentation updates and/or requests for expanded documentation enhancement a new feature or addition secrets engines generally related to a Vault secrets engine

Comments

@drewmullen
Copy link
Member

drewmullen commented May 28, 2019

hi @Dudesons thanks for the PR! I'm looking forward to this feature. Can you please look into providing docs for the new secret engine?

also, all secret engines should accept a mount_point variable with a sensible default so the vault path can be adjusted if necessary done

@PeteBoyRocket
Copy link

Are there any examples for doing the equivalent of this in the meantime? I am not clear how to do this https://www.vaultproject.io/docs/secrets/databases/mssql

$ vault write database/config/my-mssql-database \
    plugin_name=mssql-database-plugin \
    connection_url='sqlserver:https://{{username}}:{{password}}@localhost:1433' \
    allowed_roles="my-role" \
    username="vaultuser" \
    password="yourStrong(!)Password"

@Vishesh-Gupta
Copy link

Hey @jeffwecan, is there any update on this? I want to use the database secrets engine with HVAC. Could you provide some documentation for this?

@jeffwecan
Copy link
Member

@Vishesh-Gupta Sorry, this sort of expanded documentation is still outstanding. I'm looking into some general maintenance and cutting a new release over the next week or so and I'll try to revisit this issue as part of that though!

@jeffwecan jeffwecan self-assigned this Jul 8, 2021
@Vishesh-Gupta
Copy link

@jeffwecan I'd be happy to help on different parts of HVAC since I extensively use and work with Vault at my work. Let me know if you need help and I'd be happy to talk about it

@jeffwecan
Copy link
Member

@Vishesh-Gupta: Great! If you're interested in helping with some of this repository's maintenance beyond general documentation / code contributions, feel free to shoot me an email at [email protected] and we can chat about it more. 😄

@jsp-hashicorp
Copy link

Hope this helps for Database secret engine doc.

For Database Secret Engine - Dynamic Secret

Source link : https://github.com/hvac/hvac/blob/main/hvac/api/secrets_engines/database.py

resp3 = client.secrets.database.generate_credentials(
name = 'dynamic-role',
mount_point = 'database',
)
print(f'Dynamic Secret - Username: "{resp3["data"]["username"]}", Password:"{resp3["data"]["password"]}"')

For Database Secret Engine - Static Role

Source link : https://github.com/hvac/hvac/blob/main/hvac/api/secrets_engines/database.py

resp4 = client.secrets.database.get_static_credentials(
name = 'static-role',
mount_point = 'database',
)
print(f'Static Secret - Username: "{resp4["data"]["username"]}", Password:"{resp4["data"]["password"]}"')

@briantist briantist added the secrets engines generally related to a Vault secrets engine label Jun 21, 2023
@amiewei
Copy link
Contributor

amiewei commented Aug 4, 2023

hello :) i've been looking at dynamic secrets and can work on documenting this.

I've just started trying out the different dynamic secrets methods that's already in the code. I'm testing it against a local postgres db and can document the code snippets as i go. I know there are many db plugins and each of them have their own nuances, but i'm thinking for the documentation, i could provide the code examples for postgres and reference the vault documentation for details to update on specific plugins - https://developer.hashicorp.com/vault/docs/secrets/databases#database-capabilities

Let me know if this sounds like a decent approach and ill get started! would appreciate an additional set of eyes to look over. Ill prob start with a few methods around configuring the connection, roles first.

@briantist
Copy link
Contributor

Hi @amiewei , welcome! This sounds like a good approach to me, looking forward to it

@briantist
Copy link
Contributor

Resolved by #1036

Documentation Cleanup and Doctest automation moved this from To do to Done Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database database secrets engine documentation documentation updates and/or requests for expanded documentation enhancement a new feature or addition secrets engines generally related to a Vault secrets engine
Development

No branches or pull requests

7 participants