1486 fix address search in desktop menu #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undaries input during an Address Search
…ing click event to #boundaries
…and should remain reusable. Created a copy of SelectorBox called BoundariesSection that utilizes ui.boundaries.isOpen redux state instead of a local expanded state which is what SelectorBox uses. Using a redux state variable exposes the state of our BoundariesSection component to all other components, which is needed to perform event dispatches to toggle it open and closed from other components accordingly
…ries section from CouncilSelector when selecting a neighborhood council no longer utilizes a click event dispatch but instead makes use of redux closeBoundaries dispatch to set ui.boundaries.isOpen to false
…uncil gets unselected from the council selector of the boundaries section
…ood district on map
…ion when zooming out of map. Also collapse boundaries section when clicking into a neightborhood district on the map
…Selector to be consistent with other parts of codebase
…e address search input from any component. this fixed a bug. searching A, selecting boundary B and searching A again now works.
…s search input during zoom out when clicking outside of a zoomed in nc
4 tasks
…e others think it is ok to do this in react class components. removed TODO comment and added optional chaining to addressSearchIsEmpty
…ariesSection in CouncilSelector/index.js instead of relative path
hqasmei
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1485 #1486
Wow, what a ride.
There is quite a bit here but in a nutshell, I think I got the
Address Search,BoundairesandClicking on Mapto sync and play well together as per discussed in our team meeting.If you are checking out the branch, you may need to run
npm ito get it to work since I addedlodash.debouncetopackage.jsonPlease take a look and let me know if there is anything I may have overlooked or isn't working as expected. I think with this and Bryan's bookmarking we should be pretty good with rolling out v2. Thanks in advance!
devbranchAny questions? See the getting started guide