Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Address Search in Desktop Menu #1486

Closed
4 tasks
edwinjue opened this issue Mar 27, 2023 · 0 comments · Fixed by #1497
Closed
4 tasks

Fix Address Search in Desktop Menu #1486

edwinjue opened this issue Mar 27, 2023 · 0 comments · Fixed by #1497
Assignees
Labels
Bug Something isn't working P-feature: Map Role: Frontend React front end work Size: 8pt Can be done in 31-48 hours

Comments

@edwinjue
Copy link
Member

edwinjue commented Mar 27, 2023

Overview

The Address Search in the Desktop Menu is not working correctly.
image

Currently, an end user is allowed to perform any of the following actions at any time:

  1. Select a neighborhood district directly on the Map
  2. Select a neighborhood district from the Boundaries area
  3. Search by Address in the Address Search input field

In order to fix the Address Search feature, each of the above end user actions need to be taken into account and each action should generate the expected behavior as defined in Action Items below

Action Items

  • 1. Clicking a neighborhood district on map should:

    • Debounce
    • Clear out address search field
    • Populate boundaries field
    • Zoom into neighborhood district
  • 2. Selecting a neighborhood district from the Boundaries area should:

    • Clear out address search field
    • Populate boundaries field
    • Collapse Boundaries area if expanded
    • Zoom into neighborhood district
  • 3. Address Search input event handler should:

    • Debounce
    • Clear out/reset boundaries field
    • Collapse Boundaries area if expanded
    • Check if address is valid (within los angeles jurisdiction)
      • If not,
        • Display error toast
        • Clear the search field
      • If it is,
        • Clear Boundary
        • Collapse Boundary area if it is expanded
        • Zoom into the area on map
  • If we are zoomed in because of a search input event handler,

    • Listen, detect and handle all zoom-out related events

Resources/Instructions

Refer to Algorithm

@edwinjue edwinjue added Bug Something isn't working Role: Frontend React front end work Size: 8pt Can be done in 31-48 hours P-feature: Map labels Mar 27, 2023
@edwinjue edwinjue assigned henurah and edwinjue and unassigned edwinjue and henurah Mar 30, 2023
@edwinjue edwinjue self-assigned this Apr 6, 2023
@edwinjue edwinjue linked a pull request Apr 6, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working P-feature: Map Role: Frontend React front end work Size: 8pt Can be done in 31-48 hours
Projects
Development

Successfully merging a pull request may close this issue.

2 participants