Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1486 fix address search in desktop menu #1497

Merged
merged 33 commits into from
Apr 10, 2023
Merged

1486 fix address search in desktop menu #1497

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
3aa2f47
added resetBoundaries and called it from onGeocoderResult to reset Bo…
edwinjue Apr 3, 2023
5908ffd
added comments for address search and boundaries event handlers
edwinjue Apr 3, 2023
2348ead
initial debounce
edwinjue Apr 3, 2023
3fbc9b4
moved debounce options to settings and added comments
edwinjue Apr 4, 2023
bf7d8d4
removed console.log
edwinjue Apr 4, 2023
d584d2f
removed unused code
edwinjue Apr 4, 2023
ed070ed
refactored debounce to call wrapper with values defined in settings
edwinjue Apr 4, 2023
d0c4422
initial map debounce
edwinjue Apr 4, 2023
dea1e16
initial resetAddressSearch
edwinjue Apr 4, 2023
e633cdd
renamed updateCouncilsFilter to dispatchUpdateCouncilsFilter in Counc…
edwinjue Apr 4, 2023
06a8a15
initial debouncedHandleDelete
edwinjue Apr 4, 2023
5a33cb4
initial toggleBoundaires to close boundaries selector box by dispatch…
edwinjue Apr 5, 2023
28313b7
initial refactor to move SelectorBox local state to redux store
edwinjue Apr 5, 2023
3df53a1
restored SelectorBox back to original since it is a common component …
edwinjue Apr 5, 2023
1080287
boundaries section now closes from address search. closing the bounda…
edwinjue Apr 5, 2023
385b905
reset address search input when a previously selected neighborhood co…
edwinjue Apr 5, 2023
45d2b72
added code to reset address search input when clicking on a neighborh…
edwinjue Apr 5, 2023
890df6a
added code to clear address search input and collapse boundaries sect…
edwinjue Apr 5, 2023
8ab44dd
renamed dispatchUpdateCouncilsFilter to dispatchUpdateNcId in Council…
edwinjue Apr 5, 2023
6c203a4
added comments
edwinjue Apr 5, 2023
d9ee705
added comments
edwinjue Apr 5, 2023
3770d2b
initial fix to sync boundaries and address search
edwinjue Apr 5, 2023
2fdc3db
added comments
edwinjue Apr 5, 2023
05d112d
removed concole.log
edwinjue Apr 6, 2023
ab39369
added BoundariesSection component
edwinjue Apr 6, 2023
2ae4c3b
refactor
edwinjue Apr 6, 2023
91f7192
implemented custom event handling in MapSearch to be able to clear th…
edwinjue Apr 6, 2023
928eeb9
added call to resetAddressSearch from map onClick to reset the addres…
edwinjue Apr 6, 2023
494ab32
refactored early return even though nothing wrong. do not want to hav…
edwinjue Apr 6, 2023
cc58c7e
added comment
edwinjue Apr 6, 2023
4e6a5cf
removed commented code
edwinjue Apr 6, 2023
49c8d38
updated comments and used webpack alias @components to refer to Bound…
edwinjue Apr 6, 2023
c4e6599
removed commented code
edwinjue Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
initial debouncedHandleDelete
  • Loading branch information
@edwinjue
edwinjue committed Apr 4, 2023
commit 06a8a15fc7f0a98ca7fe7a6c7a5a8f99dbec7f5e
4 changes: 3 additions & 1 deletion client/components/main/Desktop/CouncilSelector/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ const CouncilSelector = ({
}
};

// Debounced event handlers
const debouncedHandleSelect = debounce(handleSelect);
const debouncedHandleDelete = debounce(handleDelete);

return (
<>
Expand All @@ -92,7 +94,7 @@ const CouncilSelector = ({
<SelectorBox.Display>
<SelectedCouncils
items={selected}
onDelete={handleDelete}
onDelete={debouncedHandleDelete}
/>
</SelectorBox.Display>
<SelectorBox.Collapse>
Expand Down