Update Platform Implementations Links in README #9
Assignees
Comments
MrJia1997
changed the title
|
Thank you for reporting this issue. It turns out there was a bug in the logic that does include path replacement for source files and it mistakenly applied to README.md. I fixed it. |
copybara-service bot
pushed a commit
that referenced
this issue
Feb 2, 2022
*** Reason for rollback *** This causes test failures in Chromium. I would normally fix it, but currently QUICHE roll to Chromium is blocked on another CL and there are two other CLs that are complicated to roll. Please allow me to roll this one back for now, I'll be happy to help with debugging after I am able to roll the latest QUICHE into Chromium. Error is: [ RUN ] HeaderValidatorTest.NameHasInvalidChar ../../buildtools/third_party/libc++/trunk/include/array:205: _LIBCPP_ASSERT '__n < _Size' failed. out-of-bounds access in std::array<T, N> Received signal 6 #0 0x7fe693f3799f base::debug::CollectStackTrace() #1 0x7fe693c8fd3a base::debug::StackTrace::StackTrace() #2 0x7fe693c8fcf5 base::debug::StackTrace::StackTrace() #3 0x7fe693f3746c base::debug::(anonymous namespace)::StackDumpSignalHandler() #4 0x7fe6911f1200 (/lib/x86_64-linux-gnu/libpthread-2.33.so+0x131ff) #5 0x7fe690db3891 gsignal #6 0x7fe690d9d536 abort #7 0x7fe6912c941c std::__Cr::__libcpp_abort_debug_function() #8 0x7fe6953c9996 std::__Cr::array<>::operator[]() #9 0x7fe6953c95c9 http2::adapter::(anonymous namespace)::AllCharsInMap() #10 0x7fe6953c87ec http2::adapter::(anonymous namespace)::IsValidHeaderName() #11 0x7fe6953c7e15 http2::adapter::HeaderValidator::ValidateSingleHeader() #12 0x56309a95f81d http2::adapter::test::HeaderValidatorTest_NameHasInvalidChar_Test::TestBody() #13 0x56309bf0b83b testing::internal::HandleSehExceptionsInMethodIfSupported<>() #14 0x56309befc767 testing::internal::HandleExceptionsInMethodIfSupported<>() #15 0x56309beeaac1 testing::Test::Run() #16 0x56309beeb1d7 testing::TestInfo::Run() #17 0x56309beeb83d testing::TestSuite::Run() #18 0x56309bef5e7a testing::internal::UnitTestImpl::RunAllTests() #19 0x56309bf0fa3b testing::internal::HandleSehExceptionsInMethodIfSupported<>() #20 0x56309befe337 testing::internal::HandleExceptionsInMethodIfSupported<>() #21 0x56309bef5a11 testing::UnitTest::Run() #22 0x56309c167aa1 RUN_ALL_TESTS() *** Original change description *** Use static char maps in HeaderValidator::ValidateSingleHeader(). When validating header names/values against allowed characters, switching to static char maps may help with performance. This CL is otherwise not a functional change. *** PiperOrigin-RevId: 425943183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I click on the link about platform implementations in README, it shows that "The file does not exist at this commit". Does it mean that those links in the README are outdated? It is welcome to submit a PR to fix this? Thank you.
The text was updated successfully, but these errors were encountered: