Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireshark parser? #15

Open
magicalo opened this issue May 9, 2022 · 0 comments
Open

Wireshark parser? #15

magicalo opened this issue May 9, 2022 · 0 comments

Comments

@magicalo
Copy link

magicalo commented May 9, 2022

Is there a wireshark parser available anywhere? I want to explore this protocol more.
https://gitlab.com/wireshark/wireshark/-/issues/17502

CyberFlameGO pushed a commit to CyberFlameGO/quiche that referenced this issue May 10, 2022
*** Reason for rollback ***

This causes test failures in Chromium.  I would normally fix it, but currently QUICHE roll to Chromium is blocked on another CL and there are two other CLs that are complicated to roll.  Please allow me to roll this one back for now, I'll be happy to help with debugging after I am able to roll the latest QUICHE into Chromium.

Error is:
[ RUN      ] HeaderValidatorTest.NameHasInvalidChar
../../buildtools/third_party/libc++/trunk/include/array:205: _LIBCPP_ASSERT '__n < _Size' failed. out-of-bounds access in std::array<T, N>
Received signal 6
#0 0x7fe693f3799f base::debug::CollectStackTrace()
google#1 0x7fe693c8fd3a base::debug::StackTrace::StackTrace()
google#2 0x7fe693c8fcf5 base::debug::StackTrace::StackTrace()
google#3 0x7fe693f3746c base::debug::(anonymous namespace)::StackDumpSignalHandler()
google#4 0x7fe6911f1200 (/lib/x86_64-linux-gnu/libpthread-2.33.so+0x131ff)
google#5 0x7fe690db3891 gsignal
google#6 0x7fe690d9d536 abort
google#7 0x7fe6912c941c std::__Cr::__libcpp_abort_debug_function()
google#8 0x7fe6953c9996 std::__Cr::array<>::operator[]()
google#9 0x7fe6953c95c9 http2::adapter::(anonymous namespace)::AllCharsInMap()
google#10 0x7fe6953c87ec http2::adapter::(anonymous namespace)::IsValidHeaderName()
google#11 0x7fe6953c7e15 http2::adapter::HeaderValidator::ValidateSingleHeader()
google#12 0x56309a95f81d http2::adapter::test::HeaderValidatorTest_NameHasInvalidChar_Test::TestBody()
google#13 0x56309bf0b83b testing::internal::HandleSehExceptionsInMethodIfSupported<>()
google#14 0x56309befc767 testing::internal::HandleExceptionsInMethodIfSupported<>()
google#15 0x56309beeaac1 testing::Test::Run()
google#16 0x56309beeb1d7 testing::TestInfo::Run()
google#17 0x56309beeb83d testing::TestSuite::Run()
google#18 0x56309bef5e7a testing::internal::UnitTestImpl::RunAllTests()
google#19 0x56309bf0fa3b testing::internal::HandleSehExceptionsInMethodIfSupported<>()
google#20 0x56309befe337 testing::internal::HandleExceptionsInMethodIfSupported<>()
google#21 0x56309bef5a11 testing::UnitTest::Run()
google#22 0x56309c167aa1 RUN_ALL_TESTS()

*** Original change description ***

Use static char maps in HeaderValidator::ValidateSingleHeader().

When validating header names/values against allowed characters,
switching to static char maps may help with performance.

This CL is otherwise not a functional change.

***

PiperOrigin-RevId: 425943183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant