-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XDP Support #16
Comments
copybara-service bot
pushed a commit
that referenced
this issue
Dec 2, 2022
Bonnet's implementation of IcmpReachableInterface internally produces ICMP6 Echo Requests directed at a link-local address that is replied-to by the server directly, without relying on other network elements. However, we were previously constructing the ICMP6 Echo Reply incorrectly, putting in the entire packet (as is expected for ICMP errors) rather than its body. This would produce non-sensical output when used with `ping6`, namely ``` # ping6 -i 0.1 fe80::71:626f:6e65%qbone0 -c 1 PING fe80::71:626f:6e65%qbone0(fe80::71:626f:6e65) 56 data bytes Warning: time of day goes back (-3758166514911134782us), taking countermeasures. Warning: time of day goes back (-3758166514911134731us), taking countermeasures. 112 bytes from 2002:a17:51a:2b52:b0:79c:f9be:5968: icmp_seq=1 ttl=255 time=0.000 ms wrong data byte #16 should be 0x10 but was 0x0 #16 0 0 0 0 0 0 0 0 fe 80 0 0 0 0 0 0 0 0 0 71 62 6f 6e 65 80 0 fa c3 3a fb 0 1 #48 4f 53 8a 63 0 0 0 0 --- fe80::71:626f:6e65%qbone0 ping statistics --- 1 packets transmitted, 1 received, 0% packet loss, time 0ms rtt min/avg/max/mdev = 0.000/0.000/0.000/0.000 ms ``` This changes corrects the `body` passed through to actually be that of the ICMP6 Echo Request, which includes both the UNIX timeval and the counter of padding when using standard iputils ping6. This is really an entirely cosmetic issue, but it should also fix the confusion Wireshark has when looking at packet captures over QBONE, where it is not able to line up the request and reply since the data don't match. PiperOrigin-RevId: 492531951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi - I grepped the source code, but could not find support for XDP underlying quiche. I know Microsoft has added XDP support to their msquic implementation - but they don't seem to support MASQUE. Is there a plan for quiche to support XDP?
The text was updated successfully, but these errors were encountered: