Add maxSize extension support #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FikriMilano
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
shoaibmushtaq25
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Thanks @FikriMilano for this PR! Added a few comments for review. PTAL and lmk what you think!
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Outdated
Show resolved
Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Outdated
Show resolved
Hide resolved
...ure/src/test/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponentsTest.kt
Outdated
Show resolved
Hide resolved
...ure/src/test/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponentsTest.kt
Show resolved
Hide resolved
- Use Kibibytes and Mebibytes. - Add test case when answer size is above limit.
There was a problem hiding this comment.
Looks good to me! Will ask @jingtang10 to review quickly and approve!
|
Awesome, thanks! |
|
@omarismail94 The CI was having a 120000 timeout error. Let me see if re-triggering it will work. Same with this one #1678 |
|
The Instrumentation test failed due to the Firebase Android phone timing out. Re-ran it and everything passed! @jingtang10 can you PTAL at the PR and approve? |
|
@omarismail94 |
I think you do! In the Labels section on the right of the PR page, you can add the |
|
@omarismail94 |
…size-extension-support
jingtang10
requested changes
Nov 22, 2022
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Outdated
Show resolved
Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Outdated
Show resolved
Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Outdated
Show resolved
Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Outdated
Show resolved
Hide resolved
...ure/src/test/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponentsTest.kt
Outdated
Show resolved
Hide resolved
...ure/src/test/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponentsTest.kt
Outdated
Show resolved
Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Outdated
Show resolved
Hide resolved
…size-extension-support
FikriMilano
force-pushed
the
1675-maxsize-extension-support
branch
from
2f22623
to
a657118
Compare
|
@jingtang10 this is ready for another review |
jingtang10
approved these changes
Jan 6, 2023
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Outdated
Show resolved
Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Outdated
Show resolved
Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Outdated
Show resolved
Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Outdated
Show resolved
Hide resolved
...ure/src/test/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponentsTest.kt
Outdated
Show resolved
Hide resolved
...ure/src/test/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponentsTest.kt
Outdated
Show resolved
Hide resolved
...ure/src/test/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponentsTest.kt
Outdated
Show resolved
Hide resolved
…size-extension-support
jingtang10
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1675
Description
Allows Questionnaire Item to limit the maximum file size the user can upload
Alternative(s) considered
N/A
Type
Feature
Screenshots (if applicable)
N/A
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.