Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mimeType extension support #1678

Merged
merged 13 commits into from
Dec 5, 2022

Conversation

FikriMilano
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1674

Description
Clear and concise code change description.
Allows Questionnaire Item to retrieve mimeTypes from extension.

Alternative(s) considered
N/A

Type
Feature

Screenshots (if applicable)
N/A

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Contributor

@shoaibmushtaq25 shoaibmushtaq25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FikriMilano. LGTM.

@shoaibmushtaq25 shoaibmushtaq25 self-assigned this Oct 25, 2022
@FikriMilano FikriMilano mentioned this pull request Oct 27, 2022
7 tasks
@jingtang10 jingtang10 enabled auto-merge (squash) December 5, 2022 02:30
@jingtang10 jingtang10 merged commit 51a7057 into google:master Dec 5, 2022
@jingtang10 jingtang10 deleted the 1674-mimetype-extension-support branch December 5, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mimeType extension support
3 participants