Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maxSize extension support #1688

Merged
merged 17 commits into from
Jan 10, 2023
Merged

Add maxSize extension support #1688

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
eddb2ff
Implement maxSize extension
FikriMilano Oct 25, 2022
624cf29
Address review
FikriMilano Oct 25, 2022
89fd369
Trigger CI checks
FikriMilano Oct 27, 2022
9b265c0
Merge branch 'master' of github.com:google/android-fhir into 1675-max…
FikriMilano Oct 28, 2022
e38a773
Trigger CI checks
FikriMilano Oct 28, 2022
9f977e1
Merge branch 'master' of github.com:google/android-fhir into 1675-max…
FikriMilano Nov 4, 2022
46fe8a8
Trigger CI checks
FikriMilano Nov 8, 2022
b207826
Use direct conversion from Byte to other units
FikriMilano Jan 4, 2023
25de378
Update function docs
FikriMilano Jan 4, 2023
0bf3f91
Rename maxSizeInB to maxSizeInByte
FikriMilano Jan 4, 2023
df2dad2
Remove unclear test
FikriMilano Jan 4, 2023
c514d5f
Add tests for maxSizeInKiB and maxSizeInMiB
FikriMilano Jan 4, 2023
a657118
Merge branch 'master' of github.com:google/android-fhir into 1675-max…
FikriMilano Jan 4, 2023
eee6944
spotlessApply
FikriMilano Jan 4, 2023
2789c40
Address review
FikriMilano Jan 6, 2023
bf73e49
Merge branch 'master' of github.com:google/android-fhir into 1675-max…
FikriMilano Jan 6, 2023
c52d781
Merge branch 'master' into 1675-maxsize-extension-support
jingtang10 Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for maxSizeInKiB and maxSizeInMiB
  • Loading branch information
@FikriMilano
FikriMilano committed Jan 4, 2023
commit c514d5f247573f9bf653e43af6239903e04decae
14 changes: 13 additions & 1 deletion .../src/test/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponentsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,11 +495,23 @@ class MoreQuestionnaireItemComponentsTest {
}

@Test
fun maxSize_missingExtension_shouldReturnNull() {
fun maxSizeInByte_missingExtension_shouldReturnNull() {
FikriMilano marked this conversation as resolved.
Show resolved Hide resolved
val questionnaire = Questionnaire.QuestionnaireItemComponent()
assertThat(questionnaire.maxSizeInByte).isNull()
}

@Test
fun maxSizeInKiB_missingExtension_shouldReturnNull() {
val questionnaire = Questionnaire.QuestionnaireItemComponent()
assertThat(questionnaire.maxSizeInKiB).isNull()
}

@Test
fun maxSizeInMiB_missingExtension_shouldReturnNull() {
val questionnaire = Questionnaire.QuestionnaireItemComponent()
assertThat(questionnaire.maxSizeInMiB).isNull()
}

@Test
fun localizedTextSpanned_noText_shouldReturnNull() {
assertThat(Questionnaire.QuestionnaireItemComponent().localizedTextSpanned).isNull()
Expand Down