Dockerfile + README.md usage #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest to use multi stage builds instead: https://docs.docker.com/develop/develop-images/multistage-build/#name-your-build-stages. There's no need for a full "go"-aware alpine image for that. The link contains a suggestion about how to build go projects with that docker feature. |
Closed
This was referenced Mar 9, 2018
Merged
|
Closed since #66 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Dockerfile that will build Shiori based on the official Go alpine image (by using the alpine version, the resulting image will be smaller).
Comparison between using the standard image (left) vs the Alpine one (right):
It also adds a little "Usage with Docker" section to the Readme file that will help the users self-host their own shiori containers, with the ability to persist the database across container recreations.