-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended docker support #66
Extended docker support #66
Conversation
Seems great to me. I could help with that. |
@dexafree I thought about that too, but in the end having those scripts is more obvious than a single file - also see https://githubengineering.com/scripts-to-rule-them-all/. But I'm happy to add a simple |
@dexafree Done. |
8a4d66a
to
fb586cc
Compare
|
||
EXPOSE 8080 | ||
|
||
ENTRYPOINT ["/usr/bin/dumb-init", "--"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RadhiFadlillah If you wonder, what this tool is for: https://github.com/Yelp/dumb-init:
dumb-init is a simple process supervisor and init system designed to run as PID 1 inside minimal container environments (such as Docker). It is deployed as a small, statically-linked binary written in C.
Thanks @maxmeyer. BTW, I think we don't really need to add those additional scripts, especially since |
README.md
Outdated
To build the project, please run the following command. | ||
|
||
```sh | ||
bin/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, we can just use go build -o shiori
README.md
Outdated
command. | ||
|
||
```sh | ||
bin/setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, we can just use go get -d -v ./..
fb586cc
to
2869212
Compare
### Build the image | ||
|
||
```bash | ||
$ docker build -t shiori . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's a decision for #70 this needs to be replaced by bin/docker/build
.
Thanks @RadhiFadlillah. I'm looking forward for the next release of shiori. 😄 |
@RadhiFadlillah Awesome! I just realized, that you just setup the automated docker build! 👍 |
Preface
This incorparates all changes from #27 (/cc @dexafree) rebased to current master and reduces the image size by using the multistaged build feature from docker. This also reduces the surface for attacks by reducing the amount of installed packages.
Additions