Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfile #11

Closed
wants to merge 1 commit into from
Closed

Add dockerfile #11

wants to merge 1 commit into from

Conversation

viktorstrate
Copy link

Add Docker support. This file will download dependencies and install shiori inside an image. This is extremely useful for server maintainers, because it's secure and easy.

Run docker build -t shiori . to build the image
Run docker run -p 8080:8080 -d --rm --name shiori shiori to start a docker container
Run docker exec shiori shiori <COMMAND> to interact with the container

@maxmeyer
Copy link
Contributor

maxmeyer commented Mar 5, 2018

#27 and #11 trying to solve the same problem.

@maxmeyer
Copy link
Contributor

maxmeyer commented Mar 5, 2018

As written in #27: I suggest to use multi stage builds instead: https://docs.docker.com/develop/develop-images/multistage-build/#name-your-build-stages. There's no need for a full "go"-aware alpine image for that. The link contains a suggestion about how to build go projects with that docker feature.

@viktorstrate
Copy link
Author

I don't know much about Go. And I made a dockerfile for my own needs, and thought I would share it with you. But I do not know enough about Go to improve it.

Please see #27 for a better implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants