Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dropzone #31482

Merged
merged 9 commits into from
Jun 26, 2024
Merged

Refactor dropzone #31482

merged 9 commits into from
Jun 26, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jun 25, 2024 •
edited
Loading

Refactor the legacy code and remove some jQuery calls.

(some code are still copied from old code, not perfect but acceptable)

@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jun 25, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 25, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 25, 2024
@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Jun 25, 2024
@wxiaoguang wxiaoguang mentioned this pull request Jun 25, 2024
Merged
@wxiaoguang wxiaoguang force-pushed the refactor-dropzone branch 9 times, most recently from 773b6dd to 40f1ae5 Compare June 25, 2024 11:55
@wxiaoguang wxiaoguang mentioned this pull request Jun 25, 2024
Closed
silverwind
silverwind reviewed Jun 25, 2024
View reviewed changes
web_src/js/utils/dom.js Outdated Show resolved Hide resolved
silverwind
silverwind reviewed Jun 25, 2024
View reviewed changes
web_src/js/utils/dom.js Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 26, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2024
@wxiaoguang wxiaoguang merged commit a88f718 into go-gitea:main Jun 26, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the refactor-dropzone branch June 26, 2024 17:01
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 27, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b71ae6f 
* giteaofficial/main:
  Refactor issue label selection (go-gitea#31497)
  Refactor dropzone (go-gitea#31482)
  [skip ci] Updated translations via Crowdin
  Optimization of labels handling in issue_search (go-gitea#26460)
  use correct l10n string (go-gitea#31487)
  Fix overflow menu flickering on mobile (go-gitea#31484)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @silverwind @GiteaBot