Refactor issue label selection #31497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
GiteaBot
added
the
lgtm/need 2
wxiaoguang
added
the
skip-changelog
wxiaoguang
changed the title
wxiaoguang
force-pushed
the
refactor-issue-label
branch
from
d8e8edc
to
b992000
Compare
lunny
approved these changes
Jun 26, 2024
GiteaBot
added
lgtm/need 1
xlii-chl
reviewed
Jun 26, 2024
| labelQuerySliceStrings[i] = strconv.FormatInt(x, 10) | ||
| } | ||
| labelQuerySliceStrings := labelQueryParams.Values() | ||
| slices.Sort(labelQuerySliceStrings) // the sort is still needed because the underlying map of Set doesn't guarantee order |
There was a problem hiding this comment.
Little warning: probably acceptable in this case but you're sorting strings now so it will output something like 1,10,2 instead of 1,2,10.
There was a problem hiding this comment.
Don't really see the necessity.
They are IDs and are totally transparent to other modules, the only thing we need to do is to make them ordered, so string comparing or number comparing doesn't matter.
Think about another case, if we have a lot of UUIDs as IDs, we could also just sort them, and we do not really care about why A<B or A>B
delvh
approved these changes
Jun 26, 2024
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 27, 2024
* giteaofficial/main: Refactor issue label selection (go-gitea#31497) Refactor dropzone (go-gitea#31482) [skip ci] Updated translations via Crowdin Optimization of labels handling in issue_search (go-gitea#26460) use correct l10n string (go-gitea#31487) Fix overflow menu flickering on mobile (go-gitea#31484)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #26460, rename the variable names to follow Golang standard, and use
container.Set[string]directly to simplify the code.