Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue comments are not updated after editing (if attachments are disabled) #31485

Closed
ukct opened this issue Jun 25, 2024 · 2 comments
Closed
Labels

Comments

@ukct
Copy link

ukct commented Jun 25, 2024

Description

Attempting to edit a comment and then save it results in a javascript error withn repo-issue-edit.js, if attachments are disabled.

To reproduce:

From the UI:

  • create new issue
  • add a comment
  • edit that comment
  • saving the edit will throw a javascript error in the saveAndRefresh method in repo-issue-edit.js, when attempting to iterate through dropzoneInst

This appears to be a new issue introduced in 1.22.

Gitea Version

1.22.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Helm gitea chart

Database

PostgreSQL

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 25, 2024

Regression of Remove jQuery .map() and enable eslint rules for it (#29272)


The problem will be fixed by: Refactor dropzone #31482

For 1.22 it needs a simple&separate fix: Fix dropzone JS error when attachment is disabled #31486

@wxiaoguang
Copy link
Contributor

Fixed by #31486 and it is in 1.22-nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants