-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve natural sort #29611
Improve natural sort #29611
Conversation
How does the current algorithm compare to that package in terms of memory consumption/speed? Would it make sense to just depend on that package? If current implementation is kept, maybe add some test cases from https://github.com/maruel/natural as well. |
|
And I think the current tests are good enough. |
Right, if it doesn't even support unicode, it's a no-go. |
* giteaofficial/main: Run editorconfig-checker on `locale_en-US.ini` (go-gitea#29608) bump protobuf module (go-gitea#29617) Add ac claim for old docker/build-push-action@v3 / current buildx gha cache (go-gitea#29584) Skip email domain check when admins edit user emails (go-gitea#29609) Improve natural sort (go-gitea#29611) Add empty repo check in `DetectAndHandleSchedules` (go-gitea#29606) Fix contributor graphs mobile layout and responsiveness (go-gitea#29597) Skip email domain check when admin users adds user manually (go-gitea#29522) Replace more `gt-` with `tw-`, update frontend docs (go-gitea#29595) Remove unnecessary ctxData for "attachments" template (go-gitea#29600) Adjust tailwind content globs (go-gitea#29596) Use flex wrap to layout the PR update button (go-gitea#29590) Make "/user/login" page redirect if the current user has signed in (go-gitea#29583) [skip ci] Updated translations via Crowdin Fix projects mode bugs (go-gitea#29593) Regenerate fomantic lockfile and build it with our browserslist (go-gitea#29560) Do not exceed display for the PR page buttons on smaller screens (go-gitea#29418) Add aria-label to the navbar menu button (go-gitea#29587)
* origin/main: (29 commits) Tweak actions color and borders (go-gitea#29640) Add download URL for executable files (go-gitea#28260) Move all login and account creation page labels to be above inputs (go-gitea#29432) Avoid issue info panic (go-gitea#29625) Cache repository default branch commit status to reduce query on commit status table (go-gitea#29444) Avoid unexpected panic in graceful manager (go-gitea#29629) Add a link for the recently pushed branch notification (go-gitea#29627) Fix wrong header of org project view page (go-gitea#29626) Detect broken git hooks (go-gitea#29494) Sync branches to DB immediately when handle git hook calling (go-gitea#29493) Fix wrong line number in code search result (go-gitea#29260) Make wiki default branch name changable (go-gitea#29603) A small refactor for agit implementation (go-gitea#29614) Update Twitter Logo (go-gitea#29621) Fix 500 error when adding PR comment (go-gitea#29622) Run editorconfig-checker on `locale_en-US.ini` (go-gitea#29608) bump protobuf module (go-gitea#29617) Add ac claim for old docker/build-push-action@v3 / current buildx gha cache (go-gitea#29584) Skip email domain check when admins edit user emails (go-gitea#29609) Improve natural sort (go-gitea#29611) ...
Hugely simplify the code, and add more tests (only new approach could pass)