Fix wrong line number in code search result

[yp05327]

Fix #29136

Before:
The result is a table and all line numbers are all in one row.

After:

Updated:
added active class to the target line.

[lunny]

The map is unordered? How about using two slices?

[wxiaoguang]

1. It should use slices, but not map. Map is unordered.
2. It should highlight the whole code block first, then split it. Otherwise it doesn't work well with multiple line highlighting.

[wxiaoguang]

There seems to be CI failures

[yp05327]

CI failure is caused by the file which is end with two \n, and we have another issue caused by this:

[yp05327]

It is caused by the code here. We removed \n, and it seems that chroma didn't add newlines.

[silverwind]

If your example has single trailing \n, then UI should not render it, but monaco should.

[yp05327]

So 3 lines here is expected? even there are only two lines below.

And we should also not render it in search results?

[yp05327]

If the content is aaa\n\n, when we search aaa, we will get aaa\n.
And the \n here is not the last \n of this file, so we should render it in the search result?
But if the content is aaa\n, when we search aaa, we will also get aaa\n.
But the \n here is the last \n in this file, so how should we deal with it in this case? 🤔

[silverwind]

So 3 lines here is expected? even there are only two lines below.

And we should also not render it in search results?

a\n expectance is "1 line", no final newline in code view or search results, final newline visible in monaco.
a\n\n expectance is "2 lines", no final newline in code view or search results, final newline visible in monaco.

[silverwind]

If the content is aaa\n\n, when we search aaa, we will get aaa\n. And the \n here is not the last \n of this file, so we should render it in the search result? But if the content is aaa\n, when we search aaa, we will also get aaa\n. But the \n here is the last \n in this file, so how should we deal with it in this case? 🤔

Search should just be a simple "contains" query in the raw text, including matching any trailing newline. It is only hidding during view rendering, does not affect the search.

[silverwind]

It's indented behaviour that final newline does not render in code view and this matches GitHub behaviour. It's just that our line count is off by 1 if there is a final newline.

[lunny]

[yp05327]

What is your test content?

[wxiaoguang]

I think it could just do this : 5f8ff71 , no more trailing EOL trick.