Make "/user/login" page redirect if the current user has signed in #29583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
type/bug
backport/v1.21
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wxiaoguang
force-pushed
the
fix-login-redirect
branch
2 times, most recently
from
87ad09e
to
78cdeb2
Compare
wxiaoguang
force-pushed
the
fix-login-redirect
branch
from
78cdeb2
to
9e0ed9e
Compare
lunny
approved these changes
Mar 4, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
force-pushed
the
fix-login-redirect
branch
from
9e0ed9e
to
67248fe
Compare
wxiaoguang
commented
Mar 4, 2024
| @@ -79,7 +79,7 @@ func assertPagesMetas(t *testing.T, expectedNames []string, metas any) { | |||
| func TestWiki(t *testing.T) { | |||
| unittest.PrepareTestEnv(t) | |||
|
|
|||
| ctx, _ := contexttest.MockContext(t, "user2/repo1/wiki/?action=_pages") | |||
| ctx, _ := contexttest.MockContext(t, "user2/repo1/wiki") | |||
There was a problem hiding this comment.
Hint: the old test seems incorrect. The ?action=_pages should be tested below by WikiPages L96
silverwind
approved these changes
Mar 4, 2024
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.21. @wxiaoguang, please send one manually. 🍵 |
GiteaBot
added
backport/manual
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Mar 5, 2024
wxiaoguang
added a commit
that referenced
this pull request
Mar 5, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 6, 2024
* giteaofficial/main: Run editorconfig-checker on `locale_en-US.ini` (go-gitea#29608) bump protobuf module (go-gitea#29617) Add ac claim for old docker/build-push-action@v3 / current buildx gha cache (go-gitea#29584) Skip email domain check when admins edit user emails (go-gitea#29609) Improve natural sort (go-gitea#29611) Add empty repo check in `DetectAndHandleSchedules` (go-gitea#29606) Fix contributor graphs mobile layout and responsiveness (go-gitea#29597) Skip email domain check when admin users adds user manually (go-gitea#29522) Replace more `gt-` with `tw-`, update frontend docs (go-gitea#29595) Remove unnecessary ctxData for "attachments" template (go-gitea#29600) Adjust tailwind content globs (go-gitea#29596) Use flex wrap to layout the PR update button (go-gitea#29590) Make "/user/login" page redirect if the current user has signed in (go-gitea#29583) [skip ci] Updated translations via Crowdin Fix projects mode bugs (go-gitea#29593) Regenerate fomantic lockfile and build it with our browserslist (go-gitea#29560) Do not exceed display for the PR page buttons on smaller screens (go-gitea#29418) Add aria-label to the navbar menu button (go-gitea#29587)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29582 and maybe more.
Maybe fix #29116