Fix timezone on issue deadline #11697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems go to me. Client sends UTC and this should convert to server time zone. Can we keep the format change to // FormatDate formats a date in YYYY-MM-DD server time zone
func (ts TimeStamp) FormatDate() string {
return time.Unix(int64(ts), 0).String()[:10]
}And use that instead of |
GiteaBot
added
the
lgtm/need 2
|
Done |
silverwind
approved these changes
May 30, 2020
GiteaBot
added
lgtm/need 1
zeripath
approved these changes
Jun 5, 2020
GiteaBot
added
lgtm/done
|
I think this fixes some other date based bugs too but I don't have the issue numbers to have |
|
@CirnoT please send backport :) |
CirnoT
added a commit
to CirnoT/gitea
that referenced
this pull request
Jun 6, 2020
* Fix timezone on issue deadline * FormatDate Co-authored-by: zeripath <[email protected]> (cherry picked from commit bbe13b6)
zeripath
pushed a commit
that referenced
this pull request
Jun 6, 2020
* Fix timezone on issue deadline * FormatDate Co-authored-by: zeripath <[email protected]> (cherry picked from commit bbe13b6)
7 tasks
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Fix timezone on issue deadline * FormatDate Co-authored-by: zeripath <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11686
Closes #11688
Ensures that deadline is saved in server's timezone, not UTC.