Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue due date affected by time zone #11686

Closed
silverwind opened this issue May 29, 2020 · 1 comment · Fixed by #11697
Closed

Issue due date affected by time zone #11686

silverwind opened this issue May 29, 2020 · 1 comment · Fixed by #11697

Comments

@silverwind
Copy link
Member

silverwind commented May 29, 2020 •
edited
Loading

Setting a issue due date send a full UTC date due_date: "2020-05-25T00:00:00.000Z" to the backend but depending on the user's time zone, the displayed date may not be 2020-05-25. We should probably convert the time to 00:00 in the user's current time zone and then send UTC for that.
@silverwind silverwind mentioned this issue May 29, 2020
Merged
silverwind added a commit to silverwind/gitea that referenced this issue May 29, 2020
@silverwind
Fix issue due date always being UTC
1ee4826 
Fixes: go-gitea#11686
@silverwind silverwind mentioned this issue May 29, 2020
Closed
@silverwind
Copy link
Member Author

I guess a better fix is to display the date as UTC (instead of local as right now) while continuing to store 00:00 UTC in the database.

silverwind added a commit to silverwind/gitea that referenced this issue May 29, 2020
@silverwind
Display issue due date as UTC yyyy-mm-dd
765fa1e 
Previous version did convert to local time zone which was incorrect
because the due date is stored as 00:00 utc and it should not be
timezone-converted as it may display a different day.

Fixes: go-gitea#11686
@silverwind silverwind mentioned this issue May 29, 2020
Closed
@CirnoT CirnoT mentioned this issue May 30, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Nov 18, 2020
Open
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@silverwind