Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display issue due date as UTC yyyy-mm-dd #11688

Closed
wants to merge 2 commits into from

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 29, 2020

Previous version did convert to server time zone which was incorrect because the due date is stored as 00:00 utc and it should not be timezone-converted as it may display a different day.

Fixes: #11686

Previous version did convert to local time zone which was incorrect
because the due date is stored as 00:00 utc and it should not be
timezone-converted as it may display a different day.

Fixes: go-gitea#11686
@silverwind
Copy link
Member Author

silverwind commented May 29, 2020

This also fixes the inconsistency in due date display so these now match:

image

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 29, 2020
@CirnoT
Copy link
Contributor

CirnoT commented May 30, 2020

This also fixes the inconsistency in due date display so these now match:

Doesn't seem to work for me.

chrome_2020-05-30_21-50-11

63,16,1,"",0,8,0,0,0,0,0,0,"","","","",0,0,0,"",2020-05-31,"",1590868103,1590868103,"",0,0,0,0,0,0,0

8,8,3,1,"",0,z,"",0,0,0,0,0,"",1590883199,1590868098,1590868103,0,0

@CirnoT
Copy link
Contributor

CirnoT commented May 30, 2020

Also input element takes different date than displayed:
chrome_2020-05-30_21-55-01

@CirnoT
Copy link
Contributor

CirnoT commented May 30, 2020

Displaying UTC might be lost cause, would need to adjust every place that does format on date in code, otherwise we will always have weird differences.

@silverwind silverwind closed this May 30, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue due date affected by time zone
3 participants