API PullReviewComment HTMLPullURL should return the HTMLURL #11501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#11499 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/bug
modifies/api
techknowlogick
approved these changes
May 19, 2020
GiteaBot
added
the
lgtm/need 1
CirnoT
approved these changes
May 19, 2020
CirnoT
approved these changes
May 20, 2020
GiteaBot
added
lgtm/done
6543
reviewed
May 20, 2020
| @@ -103,7 +103,7 @@ func ToPullReviewCommentList(review *models.Review, doer *models.User) ([]*api.P | |||
| OrigCommitID: comment.OldRef, | |||
| DiffHunk: patch2diff(comment.Patch), | |||
| HTMLURL: comment.HTMLURL(), | |||
| HTMLPullURL: review.Issue.APIURL(), | |||
| HTMLPullURL: review.Issue.HTMLURL(), | |||
There was a problem hiding this comment.
damed ok this is completly my fault - at least I had an issue with it first
|
ping LG-TM |
|
@zeripath please send backport :) |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 21, 2020
…#11501) Fix go-gitea#11499 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
lafriks
pushed a commit
that referenced
this pull request
May 21, 2020
…11533) Fix #11499 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
…#11501) Fix go-gitea#11499 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11499
Signed-off-by: Andrew Thornton [email protected]