Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API PullReviewComment HTMLPullURL should return the HTMLURL #11501

Merged
merged 3 commits into from
May 21, 2020
Merged

API PullReviewComment HTMLPullURL should return the HTMLURL #11501

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e679665
API PullReviewComment HTMLPullURL should return the HTMLURL
zeripath May 19, 2020
f272ce1
Merge branch 'master' into fix-11499-HTMLPullURL-should-not-be-API
techknowlogick May 20, 2020
3e308e7
Merge branch 'master' into fix-11499-HTMLPullURL-should-not-be-API
techknowlogick May 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/convert/pull_review.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func ToPullReviewCommentList(review *models.Review, doer *models.User) ([]*api.P
OrigCommitID: comment.OldRef,
DiffHunk: patch2diff(comment.Patch),
HTMLURL: comment.HTMLURL(),
HTMLPullURL: review.Issue.APIURL(),
HTMLPullURL: review.Issue.HTMLURL(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damed ok this is completly my fault - at least I had an issue with it first

}

if comment.Line < 0 {
Expand Down