Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [API] ListPullReviewComments: HTMLPullURL is not pull.HTMLURL #11499

Closed
6543 opened this issue May 19, 2020 · 1 comment · Fixed by #11501
Closed

[BUG] [API] ListPullReviewComments: HTMLPullURL is not pull.HTMLURL #11499

6543 opened this issue May 19, 2020 · 1 comment · Fixed by #11501

Comments

@6543
Copy link
Member

6543 commented May 19, 2020

as title

example:
Get: http:https://localhost:3000/api/v1/repos/test01/Reviews/issues/1
expect: http:https://localhost:3000/test01/Reviews/pulls/1
@6543
Copy link
Member Author

6543 commented May 19, 2020

came up in https://gitea.com/gitea/go-sdk/pulls/338

zeripath added a commit to zeripath/gitea that referenced this issue May 19, 2020
@zeripath
API PullReviewComment HTMLPullURL should return the HTMLURL
e679665 
Fix go-gitea#11499

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue May 19, 2020
Merged
techknowlogick added a commit that referenced this issue May 21, 2020
@zeripath @techknowlogick
API PullReviewComment HTMLPullURL should return the HTMLURL (#11501)
0b8b81e 
Fix #11499

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
zeripath added a commit to zeripath/gitea that referenced this issue May 21, 2020
@zeripath @techknowlogick
API PullReviewComment HTMLPullURL should return the HTMLURL (go-gitea…
0a4f509 
…#11501)

Fix go-gitea#11499

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
@zeripath zeripath mentioned this issue May 21, 2020
Merged
lafriks pushed a commit that referenced this issue May 21, 2020
@zeripath @techknowlogick
API PullReviewComment HTMLPullURL should return the HTMLURL (#11501) (#…
8bde2e9 
…11533)

Fix #11499

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@zeripath @techknowlogick
API PullReviewComment HTMLPullURL should return the HTMLURL (go-gitea…
f10fe09 
…#11501)

Fix go-gitea#11499

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API PullReviewComment HTMLPullURL should return the HTMLURL zeripath/gitea
1 participant
@6543