Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and fix GetApprovalCounts #11086

Merged
merged 2 commits into from
Apr 16, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 16, 2020

close #11056

simple code can make things easy understandable and creat less issues

thanks to @CirnoT for helping me finding the related code

@6543 6543 changed the title Fix review count function [BugFix] ReviewCount: GetApprovalCounts func sorted wrong Apr 16, 2020
@codecov-io
Copy link

Codecov Report

Merging #11086 into master will increase coverage by 0.07%.
The diff coverage is 36.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11086      +/-   ##
==========================================
+ Coverage   43.46%   43.54%   +0.07%     
==========================================
  Files         597      598       +1     
  Lines       84706    84798      +92     
==========================================
+ Hits        36821    36922     +101     
+ Misses      43344    43331      -13     
- Partials     4541     4545       +4     
Impacted Files Coverage Δ
models/issue_comment.go 46.68% <ø> (ø)
models/migrations/migrations.go 3.50% <ø> (ø)
models/migrations/v136.go 0.00% <0.00%> (ø)
models/repo_language_stats.go 66.37% <ø> (ø)
modules/analyze/code_langauge.go 81.25% <ø> (ø)
modules/auth/sso/basic.go 50.81% <0.00%> (+7.15%) ⬆️
modules/git/repo_language_stats.go 66.17% <ø> (ø)
modules/indexer/code/bleve.go 64.70% <ø> (ø)
routers/api/v1/user/watch.go 0.00% <0.00%> (ø)
routers/repo/http.go 42.60% <0.00%> (+1.27%) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0040f8b...744fdd8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 16, 2020
@lafriks lafriks added this to the 1.12.0 milestone Apr 16, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 16, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 16, 2020
@lafriks lafriks merged commit a4cab2b into go-gitea:master Apr 16, 2020
@6543 6543 deleted the fix-review-counts branch April 16, 2020 13:02
@zeripath zeripath changed the title [BugFix] ReviewCount: GetApprovalCounts func sorted wrong Fix Approval Counts due to poor sorting in GetApprovalCounts May 17, 2020
@zeripath zeripath changed the title Fix Approval Counts due to poor sorting in GetApprovalCounts Simplify and fix GetApprovalCounts May 17, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Reviews not corect sorted to pulls in Pull-List-View
5 participants