Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and fix GetApprovalCounts #11086

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Simplify and fix GetApprovalCounts #11086

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7738cf4
FIX by simplify
6543 Apr 16, 2020
744fdd8
code reformat and optimize
6543 Apr 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
code reformat and optimize
  • Loading branch information
@6543
6543 committed Apr 16, 2020
commit 744fdd8392dfce81f7810b11e87ce322b139494e
9 changes: 7 additions & 2 deletions models/issue_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,13 +523,18 @@ func (issues IssueList) GetApprovalCounts() (map[int64][]*ReviewCount, error) {
}

func (issues IssueList) getApprovalCounts(e Engine) (map[int64][]*ReviewCount, error) {
rCounts := make([]*ReviewCount, 0, 6*len(issues))
rCounts := make([]*ReviewCount, 0, 2*len(issues))
ids := make([]int64, len(issues))
for i, issue := range issues {
ids[i] = issue.ID
}
sess := e.In("issue_id", ids)
err := sess.Select("issue_id, type, count(id) as `count`").Where("official = ?", true).GroupBy("issue_id, type").OrderBy("issue_id").Table("review").Find(&rCounts)
err := sess.Select("issue_id, type, count(id) as `count`").
Where("official = ?", true).
GroupBy("issue_id, type").
OrderBy("issue_id").
Table("review").
Find(&rCounts)
if err != nil {
return nil, err
}
Expand Down