Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Reviews not corect sorted to pulls in Pull-List-View #11056

Closed
6543 opened this issue Apr 13, 2020 · 7 comments · Fixed by #11086
Closed

[BUG] Reviews not corect sorted to pulls in Pull-List-View #11056

6543 opened this issue Apr 13, 2020 · 7 comments · Fixed by #11086
Labels
Milestone

Comments

@6543
Copy link
Member

6543 commented Apr 13, 2020

Gitea Version: 1.12.0+dev-72-g2c25e75dc

example pull https://gitea.com/gitnex/GitNex/pulls/398
has 1 aprofal and 1 rejection on pull-list-view but rejection was aproved later from same user

@6543
Copy link
Member Author

6543 commented Apr 13, 2020

Screenshot at 2020-04-13 04-27-10

does not match with

Screenshot at 2020-04-13 04-27-22

@6543
Copy link
Member Author

6543 commented Apr 13, 2020

same thing if you only aprove ... I guess: approvals are als counted as change-requests - didn't looket ito the code jet

@6543
Copy link
Member Author

6543 commented Apr 14, 2020

cant reproduce on current master - looks like the pull for review-request fixed this

@6543 6543 closed this as completed Apr 14, 2020
@6543 6543 reopened this Apr 15, 2020
@6543
Copy link
Member Author

6543 commented Apr 15, 2020

Looks like issue is till here :/

@6543
Copy link
Member Author

6543 commented Apr 15, 2020

as "eider" pointed out on discord:

if len(rCounts) > 0 {

if i force search to give me only one PR
the count is fine
but if in list there's at least one other issue
with requested change
the count goes to wrong issue
the "1 change request"
should go to other issue in list
but it isnt there!

@6543
Copy link
Member Author

6543 commented Apr 16, 2020

I'll take this

@6543 6543 changed the title [BUG] Recalc of Disaproved Reviews not working Pull-List-View [BUG] Reviews not corect sorted to pulls in Pull-List-View Apr 16, 2020
@lafriks lafriks added this to the 1.12.0 milestone Apr 16, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants