make avatar lookup occur at image request

speed up page generation by making avatar lookup occur at the browser
not at page generation

modules/base/tool.go

@@ -211,7 +211,7 @@ func SizedAvatarLink(email string, size int) string {
 // which includes app sub-url as prefix. However, it is possible
 // to return full URL if user enables Gravatar-like service.
 func AvatarLink(email string) string {
- return SizedAvatarLink(email, DefaultAvatarSize)
+ return setting.AppSubURL + "/avatar/" + url.PathEscape(email)
 }
 
 // FileSize calculates the file size and generate user-friendly string.

routers/routes/routes.go

@@ -417,6 +417,8 @@ func RegisterRoutes(m *macaron.Macaron) {
  })
  // ***** END: User *****
 
+ m.Get("/avatar/:email", user.AvatarByEmail)
+
  adminReq := context.Toggle(&context.ToggleOptions{SignInRequired: true, AdminRequired: true})
 
  // ***** START: Admin *****

routers/user/avatar.go

@@ -9,6 +9,7 @@ import (
  "strings"
 
  "code.gitea.io/gitea/models"
+ "code.gitea.io/gitea/modules/base"
  "code.gitea.io/gitea/modules/context"
  "code.gitea.io/gitea/modules/log"
 )
@@ -41,3 +42,15 @@ func Avatar(ctx *context.Context) {
 
  ctx.Redirect(user.RealSizedAvatarLink(size))
 }
+
+// AvatarByEmail redirects the browser to the appropriate Avatar link
+func AvatarByEmail(ctx *context.Context) {
+ email := ctx.Params(":email")
+
+ size := ctx.QueryInt("size")
+ if size == 0 {
+ size = base.DefaultAvatarSize
+ }
+
+ ctx.Redirect(base.SizedAvatarLink(email, size))
+}