Obfuscate the email address in base64

modules/base/tool.go

@@ -211,7 +211,7 @@ func SizedAvatarLink(email string, size int) string {
 // which includes app sub-url as prefix. However, it is possible
 // to return full URL if user enables Gravatar-like service.
 func AvatarLink(email string) string {
- return setting.AppSubURL + "/avatar/email-" + url.PathEscape(email)
+ return setting.AppSubURL + "/avatar/" + base64.RawURLEncoding.EncodeToString([]byte(email))
 }
 
 // FileSize calculates the file size and generate user-friendly string.

modules/base/tool_test.go

@@ -1,6 +1,7 @@
 package base
 
 import (
+ "encoding/base64"
  "net/url"
  "testing"
 
@@ -92,11 +93,11 @@ func TestSizedAvatarLink(t *testing.T) {
 
 func TestAvatarLink(t *testing.T) {
  disableGravatar()
- assert.Equal(t, "/avatar/email-"+url.PathEscape("[email protected]"), AvatarLink("[email protected]"))
+ assert.Equal(t, "/avatar/"+base64.RawURLEncoding.EncodeToString([]byte("[email protected]")), AvatarLink("[email protected]"))
 
  enableGravatar(t)
  assert.Equal(t,
- "/avatar/email-"+url.PathEscape("[email protected]"),
+ "/avatar/"+base64.RawURLEncoding.EncodeToString([]byte("[email protected]")),
  AvatarLink("[email protected]"),
  )
 }

modules/repository/commits_test.go

@@ -6,7 +6,7 @@ package repository
 
 import (
  "container/list"
- "net/url"
+ "encoding/base64"
  "testing"
  "time"
 
@@ -115,7 +115,7 @@ func TestPushCommits_AvatarLink(t *testing.T) {
  pushCommits.AvatarLink("[email protected]"))
 
  assert.Equal(t,
- "/avatar/email-"+url.PathEscape("[email protected]"),
+ "/avatar/"+base64.RawURLEncoding.EncodeToString([]byte("[email protected]")),
  pushCommits.AvatarLink("[email protected]"))
 }
 

routers/routes/routes.go

@@ -417,7 +417,7 @@ func RegisterRoutes(m *macaron.Macaron) {
  })
  // ***** END: User *****
 
- m.Get("/avatar/email-:email", user.AvatarByEmail)
+ m.Get("/avatar/:email", user.AvatarByEmail)
 
  adminReq := context.Toggle(&context.ToggleOptions{SignInRequired: true, AdminRequired: true})
 

routers/user/avatar.go

@@ -5,6 +5,7 @@
 package user
 
 import (
+ "encoding/base64"
  "errors"
  "strconv"
  "strings"
@@ -47,7 +48,12 @@ func Avatar(ctx *context.Context) {
 // AvatarByEmail redirects the browser to the appropriate Avatar link
 func AvatarByEmail(ctx *context.Context) {
  email := ctx.Params(":email")
- if email == "" {
+ addr, err := base64.RawURLEncoding.DecodeString(email)
+ email = string(addr)
+ if err != nil {
+ ctx.ServerError("invalid email address", err)
+ return
+ } else if email == "" {
  ctx.ServerError("invalid email address", errors.New("email cannot be empty"))
  return
  }